blockfrost Backend _get_script patches#428
Merged
cffls merged 3 commits intoPython-Cardano:mainfrom Mar 1, 2025
Merged
Conversation
cast script_type to int for the method PlutusScript.from_version
capitalisation mistake startswith in _gets_script
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 33 33
Lines 4744 4744
Branches 1134 1134
=======================================
Hits 4221 4221
Misses 368 368
Partials 155 155 ☔ View full report in Codecov by Sentry. |
cffls
approved these changes
Mar 1, 2025
Collaborator
cffls
left a comment
cffls
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated startsWith -> startswith, cast script_type[-1] to int for PlutusScript.from_version method